eclib: 20190909 -> 20210625, import sage update patch#123692
eclib: 20190909 -> 20210625, import sage update patch#123692SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
11.by: package-maintainer
|
Result of 2 packages skipped due to time constraints:
2 packages built successfully:
|
There was a problem hiding this comment.
The update looks non-trivial. It has been a while since the last one, which might make bugs or other potentially breaking changes in behavior more likely. I would tend towards waiting a bit longer.
You're more in touch with the upstream (sage) developments than I am these days, so I actually do think you're (one of the) best person(s) to decide this. Since you don't seem to be opposed to waiting, let's wait a bit.
Edit: "A bit" is pretty vague. I'll let you decide what exactly that means here ;) Feel free to ping me when you think it is time to reconsider this.
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
Thanks for the review! I think I'll ping again you once this reaches a Sage beta.
The main reason for the change is that v20210503 is not tagged. Combined with the fact that eclib release tarballs are now manually uploaded by the developer (no longer just a repository snapshot automatically created by GitHub), it looked like the most authoritative source.
There was a problem hiding this comment.
I think I'll ping again you once this reaches a Sage beta.
👍
The main reason for the change is that v20210503 is not tagged. Combined with the fact that eclib release tarballs are now manually uploaded by the developer (no longer just a repository snapshot automatically created by GitHub), it looked like the most authoritative source.
I see, thank you for clarifying. It would be nice to add this information to the package declaration. I like to put information like "releases not tagged, update hash on src on update" near the version attribute where it is easy to spot when someone tries to update (and visible in the diff when reviewing and update).
A comment about the manually uploaded release tarballs would also be nice to have.
There was a problem hiding this comment.
Why can't we ping upstream that they start to tag the releases again? This just makes downstream life harder.
collares
changed the title
|
Result of 3 packages built:
|
4 participants
Motivation for this change
Package update.
This employs the same "
fetchpatchto fetch a diff fromsagetrac-mirror" strategy used in #122624 because the eclib Sage update ticket was positively reviewed but has not been merged yet. I am not in a hurry to get this in 21.05 because I think few (if any) people use eclib outside Sage, and since Sage 9.3 ships with eclib 20190909 no one expects a more recent version. But I am not the best person to decide this, so here's a PR to make all options available.Fixes #114960.
(I didn't check if the diff/patch distinction matters this time.
.diffjust seemed better because there were 20-ish commits in the Trac ticket.)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)